Skip to content

Conversation

oleks-rip
Copy link
Collaborator

High Level Overview of Change

Fix processing nonexistent field

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@oleks-rip oleks-rip requested a review from a team as a code owner June 2, 2025 23:23
@oleks-rip oleks-rip requested review from mvadari and pwang200 June 2, 2025 23:23
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (6c6f8cd) to head (411081c).
Report is 3 commits behind head on ripple/smart-escrow.

Files with missing lines Patch % Lines
src/xrpld/app/misc/WasmHostFuncImpl.cpp 80.0% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           ripple/smart-escrow   #5467     +/-   ##
=====================================================
- Coverage                 78.5%   78.4%   -0.1%     
=====================================================
  Files                      823     825      +2     
  Lines                    71574   71954    +380     
  Branches                  8455    8559    +104     
=====================================================
+ Hits                     56187   56385    +198     
- Misses                   15387   15569    +182     
Files with missing lines Coverage Δ
src/xrpld/app/misc/WasmHostFuncImpl.cpp 36.6% <80.0%> (+1.3%) ⬆️

... and 9 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oleks-rip oleks-rip force-pushed the fix_nonexistent_field branch from b08383b to 5754a81 Compare June 2, 2025 23:59
}

{
// FinishFunction + Condition
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong test description here

Copy link
Collaborator Author

@oleks-rip oleks-rip Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved 411081c

Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the one note

@oleks-rip oleks-rip force-pushed the fix_nonexistent_field branch from 5754a81 to 411081c Compare June 3, 2025 20:11
@oleks-rip oleks-rip merged commit 383b225 into XRPLF:ripple/smart-escrow Jun 4, 2025
25 of 26 checks passed
@oleks-rip oleks-rip deleted the fix_nonexistent_field branch July 28, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants