Skip to content

Conversation

legleux
Copy link
Collaborator

@legleux legleux commented May 27, 2025

High Level Overview of Change

Context of Change

Antiquated CPP reference source went 404.

curl -fSslOJL http://upload.cppreference.com/mwiki/images/b/b2/html_book_20190607.zip && md5sum html_book_20190607.zip 
curl: (22) The requested URL returned error: 404

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label May 27, 2025
@bthomee bthomee enabled auto-merge (squash) May 27, 2025 20:10
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.6%. Comparing base (cae5294) to head (a45fbd6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5453     +/-   ##
=========================================
+ Coverage     78.6%   78.6%   +0.1%     
=========================================
  Files          816     816             
  Lines        70505   70506      +1     
  Branches      8314    8286     -28     
=========================================
+ Hits         55411   55450     +39     
+ Misses       15094   15056     -38     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bthomee bthomee merged commit be668ee into XRPLF:develop May 27, 2025
26 checks passed
@legleux legleux deleted the update_cpp_ref_source branch May 30, 2025 10:54
This was referenced Jun 12, 2025
@legleux legleux mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants