Skip to content

More host functions #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 29, 2025
Merged

More host functions #5411

merged 8 commits into from
Apr 29, 2025

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Apr 28, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov Codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 24.41860% with 130 lines in your changes missing coverage. Please review.

Please upload report for BASE (ripple/smart-escrow@f37d52d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/xrpld/app/misc/WasmVM.cpp 36.8% 72 Missing ⚠️
src/xrpld/app/misc/WasmHostFuncImpl.cpp 0.0% 48 Missing ⚠️
src/xrpld/app/misc/WasmVM.h 0.0% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##             ripple/smart-escrow   #5411   +/-   ##
=====================================================
  Coverage                       ?   78.0%           
=====================================================
  Files                          ?     794           
  Lines                          ?   68668           
  Branches                       ?    8380           
=====================================================
  Hits                           ?   53554           
  Misses                         ?   15114           
  Partials                       ?       0
Files with missing lines Coverage Δ
src/xrpld/app/misc/WasmHostFuncImpl.h 100.0% <ø> (ø)
src/xrpld/app/misc/WasmVM.h 4.0% <0.0%> (ø)
src/xrpld/app/misc/WasmHostFuncImpl.cpp 35.4% <0.0%> (ø)
src/xrpld/app/misc/WasmVM.cpp 67.0% <36.8%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mvadari mvadari marked this pull request as ready for review April 29, 2025 14:51
pwang200
pwang200 approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@pwang200 pwang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for adding those quickly!

@mvadari mvadari merged commit f03b588 into XRPLF:ripple/smart-escrow Apr 29, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pwang200 pwang200 pwang200 approved these changes

@oleks-rip oleks-rip oleks-rip approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvadari @pwang200 @oleks-rip