Update size and compute cap defaults #5417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwang200
reviewed
May 1, 2025
src/test/jtx/impl/envconfig.cpp
Outdated
| cfg.FEES.gas_price = 1000000; | ||
| cfg.FEES.extension_compute_limit = 1'000'000; | ||
| cfg.FEES.extension_size_limit = 100'000; | ||
| cfg.FEES.gas_price = 1'000'000; // 1 XRP = 1,000,000 micro-drops |
There was a problem hiding this comment.
1 XRP = 1,000,000 micro-drops? what is the difference between drop and micro-drops?
There was a problem hiding this comment.
Oops, typo - should be "1 drop = 1 million micro-drops", fixed
pwang200
reviewed
May 1, 2025
| # | ||
| # Example: | ||
| # gas_price = 2000000 # 2 drops per gas | ||
| # gas_price = 1000000 # 1 drop per gas |
There was a problem hiding this comment.
I vote for lower the price. Olek's base58 conversion example took 200k gas, so 0.2 XRP, about $0.45. seems high.
There was a problem hiding this comment.
Only for Devnet purposes, not for mainnet - so it's easier to track gas usage. If you'd prefer lower even for the Devnet I can do like 1k microdrops
oleks-rip
approved these changes
May 1, 2025
pwang200
approved these changes
May 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ripple/smart-escrow #5417 +/- ##
=====================================================
Coverage ? 77.9%
=====================================================
Files ? 797
Lines ? 68967
Branches ? 8415
=====================================================
Hits ? 53749
Misses ? 15218
Partials ? 0
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
New defaults are 100kb size cap, 1 million gas cap
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)