docs: Revert peer port to 51235 #5299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5299 +/- ##
=======================================
Coverage 77.9% 77.9%
=======================================
Files 791 791
Lines 68006 68006
Branches 8352 8347 -5
=======================================
+ Hits 52962 52968 +6
+ Misses 15044 15038 -6 see 2 files with indirect coverage changes |
q73zhao
pushed a commit
that referenced
this pull request
Feb 24, 2025
Reverts the [port_peer] back to the legacy port 51235 rather than to the default port 2459, to avoid potentially inconveniencing existing operators.
This was referenced Feb 26, 2025
Closed
Merged
Closed
yinyiqian1
pushed a commit
to yinyiqian1/rippled
that referenced
this pull request
Jul 11, 2025
Reverts the [port_peer] back to the legacy port 51235 rather than to the default port 2459, to avoid potentially inconveniencing existing operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Following up on #5290, this change sets the
[port_peer]back to the legacy port 51235 rather than to the default port 2459.Context of Change
The config is part of the binary and, unless an explicit config is passed, the behavior of the binary will unexpectedly be different when the port changes. As the binary would then use a different port, it would possibly make the server inaccessible depending on how routes and firewalls are configured. To err on the safe side, this change restores the port to the legacy value as it was, but still recommends using the default port for new deployments.
Type of Change