docs(BUILD): add -j $(nproc) #5288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves build times.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5288 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 816 816
Lines 70505 70505
Branches 8292 8290 -2
=======================================
+ Hits 55438 55441 +3
+ Misses 15067 15064 -3 see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
legleux
reviewed
Feb 13, 2025
legleux
approved these changes
Feb 13, 2025
tequdev
reviewed
Feb 13, 2025
| ``` | ||
| cmake --build . | ||
| cmake --build . -j $(nproc) |
There was a problem hiding this comment.
nproc is not available on macos.
Since BUILD.md mentions building on Linux/Windows/Mac, it would be helpful to include the commands for each.
I usually use sysctl -n hw.logicalcpu on macos.
There was a problem hiding this comment.
Yes, I forgot to mention that also.
brew install coreutils will get you nproc instead of that malarky.
This was referenced Jun 12, 2025
Merged
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This improves build times. I think the time is cut to about 1/6 for me - a big difference. I am not sure if there is a situation when it should not be used.
Context of Change
BUILD instructions
Type of Change
.gitignore, formatting, dropping support for older tooling)