Fix levelization script to ignore commented includes #5194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5194 +/- ##
=======================================
Coverage 78.0% 78.0%
=======================================
Files 789 789
Lines 66955 66955
Branches 8110 8108 -2
=======================================
+ Hits 52215 52219 +4
+ Misses 14740 14736 -4 see 4 files with indirect coverage changes |
ximinez
reviewed
Nov 18, 2024
This is a more universal way to detect that the line is commented out. Co-authored-by: Ed Hennis <[email protected]>
ximinez
approved these changes
Dec 3, 2024
|
@vlntb Is this ready to merge? If so, please provide a good commit message to use on the merge. |
q73zhao
pushed a commit
that referenced
this pull request
Feb 24, 2025
Check to ignore single-line comments during dependency analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Issue raised in:
#5193
Context of Change
Added simple check to ignore single-line comments during dependency analysis.
Type of Change
.gitignore, formatting, dropping support for older tooling)