Proposed 2.0.1 #4905
Merged
Proposed 2.0.1 #4905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent WebSocket connections from trying to close twice. The issue only occurs in debug builds (assertions are disabled in release builds, including published packages), and when the WebSocket connections are unprivileged. The assert (and WRN log) occurs when a client drives up the resource balance enough to be forcibly disconnected while there are still messages pending to be sent. Thanks to @lathanbritz for discovering this issue in XRPLF#4822.
…away memory usage: (XRPLF#4822) * Add logging for Application.cpp sweep() * Improve lifetime management of ledger objects (`SLE`s) * Only store SLE digest in CachedView; get SLEs from CachedSLEs * Also force release of last ledger used for path finding if there are no path finding requests to process * Count more ST objects (derive from `CountedObject`) * Track CachedView stats in CountedObjects * Rename the CachedView counters * Fix the scope of the digest lookup lock Before this patch, if you asked "is it caching?" It was always caching.
Resolves a warning that was emitted from the clang compiler. Switches usage of the sprintf function to the recommended snprintf function. Warning was observed in Apple clang version 15.0.0 (clang-1500.0.40.1). Fix XRPLF#4569
Clients subscribed to `transactions` over WebSocket are being disconnected because the traffic exceeds the default `send_queue_limit` of 100. This commit changes the default configuration, not the default in code. Fix XRPLF#4866
Minor change in unit tests to improve testing scope.
This reverts commit 1d9db1b. This improves the stability of online deletion.
…LF#4846) Update the "rippled --help" message for the "-u" parameter. This documents the unit test name pattern matching rule implemented by XRPLF#4634. Fix XRPLF#4800
* Speed up the generation of coverage reports by using multiple cores. * Add codecov step to coverage workflow.
Update to XRPLF#4849, using a workaround for spurious codecov upload errors. Spurious codecov upload errors are expected in public repos which rely on PRs via forks. Retrying uploads is a decent and easy workaround.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4905 +/- ##
=========================================
Coverage ? 61.49%
=========================================
Files ? 797
Lines ? 70122
Branches ? 36238
=========================================
Hits ? 43119
Misses ? 19761
Partials ? 7242 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Highlights:
cfg/rippled-example.cfgsetssend_queue_limit = 500. Consider adopting this setting in your ownrippled.cfgin the appropriate stanza(s) for configuredwsandwssport(s).100. At100, during times when there are >200 transactions per ledger,rippledwill disconnect WebSocket clients that subscribe to thetransactionsstream.disconnectedmessage with code1008or aClient too slowdisconnection.send_queue_limit = 500fixes this issue.The base branch is
release. All releases (including betas) go inrelease. This PR will be merged with--ff-only(not squashed or rebased, and not using the GitHub UI).Type of Change
API Impact
No API impact.