Skip to content

Conversation

@godexsoft
Copy link
Collaborator

Fixes #353

Return stream malformed error instead of invalid params.

@godexsoft godexsoft requested a review from cjcobb23 November 4, 2022 17:05
@godexsoft godexsoft requested a review from cjcobb23 November 8, 2022 14:21
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godexsoft godexsoft merged commit 739dd81 into XRPLF:develop Nov 8, 2022
legleux added a commit to legleux/clio that referenced this pull request Feb 2, 2023
* add nft_history and mark certain APIs as clio-only to improve error (XRPLF#255)

* Database read throttle (XRPLF#242)

Track current outstanding read requests to the database. When the configured limit is exceeded, reject new RPCs and return rpcTOO_BUSY

* add work queue output to server_info (XRPLF#322)

* Build Clio with CentOS 7

* Implement subscription for book_changes (XRPLF#315)

Fixes XRPLF#315

* Remove useless mutex from BackendInterface and its usage from CassandraBackend (XRPLF#326)

Fixes XRPLF#304

* Fix ProbingETL toJson to serialize underlying source states (XRPLF#325)

Fixes XRPLF#323

* Throw error if server bind or listen fails (XRPLF#309)

* Throw error if server bind or listen fails

* Implement unique taging of incoming requests (XRPLF#311)

Fixes XRPLF#212

* Add rpcLGR_IDX_MALFORMED error messages to ledger sequence min and max out of range conditionals (XRPLF#336)

* Add rpcSRC_CUR_MALFORMED to badTakerPaysCurrency and rpcDST_AMT_MALFORMED to badTakerGetsCurrency (XRPLF#268) (XRPLF#333)

* Mark package release's version string (XRPLF#317)

* Add LimitRange to noripple_check (XRPLF#324)

* Add rpcDST_ISR_MALFORMED to taker_gets conditionals (XRPLF#341)

* Don't return marker in account_tx when past user specified window (XRPLF#282)

* Allow server to download cache from another clio server (XRPLF#246)

* Allow server to download cache from another clio server

* Config takes an array of clio peers. If any of these peers have a
  full cache, clio picks a peer at random to download the cache from.
  Otherwise, fall back to downloading cache from the database.

* Remove postgres support from clio (XRPLF#327)

Fixes XRPLF#310

* Add malformedAddress in conditionals (XRPLF#343)

Fixes XRPLF#272

* Return malformedOwner in ticket.owner for ledger_entry (XRPLF#344)

Fixes XRPLF#274

* Return malformedOwner for deposit_preauth.owner in ledger_entry (XRPLF#345)

Fixes XRPLF#273

* Return badMarket for same currency in taker_gets and taker_pays in book_offers (XRPLF#357)

Fixes XRPLF#269

* Fix bug on cache download from peer when ledger not found (XRPLF#370)

* Implement an abstraction for the config (XRPLF#358)

Fixes XRPLF#321

* Rename NFT offer index to "nft_offer_index" (XRPLF#377)

Fixes XRPLF#380

* Fix nft_sell_offers/nft_buy_offers limit and marker correctness (XRPLF#342)

Fixes XRPLF#335

* Add offers to the response regardless of it being empty (XRPLF#389)

Fixes XRPLF#351

* Return account malformed error for invalid accounts (XRPLF#388)

Fixes XRPLF#349

* Add checks for empty array in accounts/accounts_proposed subscriptions (XRPLF#387)

Fixes XRPLF#347

* Implement a simple check to suppress 'validated' flag output (XRPLF#393)

Fixes XRPLF#354

* Remove checks for a valid subscription in subscribe/unsubscribe rpc to match rippled (XRPLF#386)

Fixes XRPLF#348

* Port ignore_default support for account_lines rpc (XRPLF#391)

Fixes XRPLF#375

* Return actNotFound for non-existent account in traverseOwnedNodes (XRPLF#382)

* put peers in correct spot in example config (XRPLF#376)

* Return account malformed error from account_tx when account is malformed (XRPLF#319)

* Return correct error on subscription to non-existing stream (XRPLF#390)

Fixes XRPLF#353

* return error on negative limit (XRPLF#394)

* Add clang-format git hook (XRPLF#395)

Fixes XRPLF#392

* Add limit in four additional files (XRPLF#328)

Fixes XRPLF#221

* Add Doxyfile and comments for BackendInterface.h (XRPLF#307)

Fixes XRPLF#285

* remove accountFromSeed (XRPLF#399)

* handle invalidHotWallet in gateway_balances (XRPLF#384)

* Better handle markers in nft_buy_offers and nft_sell_offers (XRPLF#400)

* Use rpcINVALID_PARAMETERS for invalid ledger_index in ledger command (XRPLF#279)

Fixes XRPLF#279

* Use rpcBAD_ISSUER for empty taker in subscribe cmd (XRPLF#352)

Fixes XRPLF#352

* Return srcIsrMalformed for taker_gets issuer in book_offers (XRPLF#266)

Fixes XRPLF#266

* Add error code extension mechanism and use malformed currency code (XRPLF#396)

Fixes XRPLF#275

* Add rpcNOT_SUPPORTED due to Clio disparity with Rippled (XRPLF#360)

Mitigates XRPLF#280

* Implement logging abstraction (XRPLF#371)

Fixes XRPLF#290

* Fix pre-commit to only check staged files

* Implement account ownership check and fix paging (XRPLF#383)

Fixes XRPLF#222

* Remove the github action package signing step

This will be done elsewhere.

* include searched_all in error response of tx (XRPLF#407)

* helper function for subscribe to ensure cleanup (XRPLF#402)

* Add closed to header for all paths of ledger_data (XRPLF#416)

Fixes XRPLF#219

* Add custom error for malformed owner and request (XRPLF#417)

Fixes XRPLF#274

* Use custom malformedAddress error in ledger_entry (XRPLF#419)

Fixes XRPLF#272

* Return lgrIdxsInvalid error for ledger_max_index less than ledger_min_index (XRPLF#339)

Fixes XRPLF#263

* Update headers to use #pragma once

* Add custom error for malformed request (XRPLF#414)

Fixes XRPLF#276

* Return srcCurMalformed on invalid taker_pays in book_offers (XRPLF#413)

Fixes XRPLF#267

* Fix source_location issue on MacOSX and Debug build (XRPLF#431)

Fixes XRPLF#428

* Implement always adding git ref to version string (XRPLF#430)

Fixes XRPLF#427

* add connection counting (XRPLF#433)

* Fix malformed output format over ws rpc (XRPLF#426)

Fixes XRPLF#405

* Remove branch name from version string (XRPLF#437)

Fixes a bug from XRPLF#430

* Implement cli parsing using boost::po (XRPLF#436)

Fixes XRPLF#367

* Update documentation and config with ssl_cert_file and ssl_key_file (XRPLF#443)

Fixes XRPLF#424

* Fix gateway balances to match rippled output (XRPLF#441)

Fixes XRPLF#271

* Update README and example config to describe start_sequence (XRPLF#438)

Fixes XRPLF#250

* Add copyright to top of each source file (XRPLF#444)

Fixes XRPLF#411

* Increase file descriptor limit (XRPLF#449)

* Update readme with more log configurations (XRPLF#447)

Fixes XRPLF#446

* Document dos_guard in example config. Log when client surpasses rate limit (XRPLF#451)

* Add unit tests for DOSGuard (XRPLF#453)

Fixes XRPLF#452

* Build macOS and Ubuntu 22.04 (XRPLF#456)

build release/x.y.z branches

* Add time measurement profiler (XRPLF#458)

Rebase

* Match format to rippled error code (XRPLF#461)

Fixes XRPLF#263

* Change error message to match rippled (XRPLF#463)

Fixes XRPLF#263

* Add requests limit to DosGuard (XRPLF#462)

Fixing XRPLF#448

* Write Clio version file from template (XRPLF#457)

* Set build version from git

* disallow untagged commits to master

* remove clang-format ingore around versionString

* config not postional parameter anymore.

* add heavy runner label

* fake clio build

* use my fork

* skip every other step

* maincpp

* no tests

* no testsfr

* revert cmakelists

---------

Co-authored-by: ledhed2222 <[email protected]>
Co-authored-by: CJ Cobb <[email protected]>
Co-authored-by: Alex Kremer <[email protected]>
Co-authored-by: Francis Mendoza <[email protected]>
Co-authored-by: Shawn <[email protected]>
Co-authored-by: manojsdoshi <[email protected]>
Co-authored-by: cyan317 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subscribe to malformed stream returns "invalidParams" instead of "malformedStream"

2 participants