fix: WorkQueue contention #2866
Merged
+173
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2866 +/- ##
===========================================
- Coverage 81.86% 81.84% -0.03%
===========================================
Files 381 381
Lines 14417 14423 +6
Branches 7935 7933 -2
===========================================
+ Hits 11803 11805 +2
- Misses 1446 1447 +1
- Partials 1168 1171 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathbunnyru
reviewed
Dec 19, 2025
Added a TODO comment to investigate single-thread behavior.
mathbunnyru
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some performance issues in the recently changed WorkQueue with priority support.
The way this was fixed is by creating a micro benchmark and copying the old code into the benchmark to compare against. I'm leaving the benchmark in so that we can always quickly measure again if we need to.
Result of these changes is ~2x performance on 8 threads with 5000 queue limit (similar to s1/s2 setup).