Skip to content

Conversation

@PeterChen13579
Copy link
Collaborator

No description provided.

@PeterChen13579 PeterChen13579 changed the title Fix: keyspace comments refactor: keyspace comments Oct 8, 2025
Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small changes, overall, looks good, thank you for fixing this!

@PeterChen13579 PeterChen13579 changed the title refactor: keyspace comments Refactor: keyspace comments Oct 8, 2025
@PeterChen13579 PeterChen13579 changed the title Refactor: keyspace comments refactor: Keyspace comments Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.58%. Comparing base (dc5f8b9) to head (fd2b85b).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/data/KeyspaceBackend.hpp 0.00% 12 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (20.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2684   +/-   ##
========================================
  Coverage    79.57%   79.58%           
========================================
  Files          385      385           
  Lines        16133    16134    +1     
  Branches      8449     8449           
========================================
+ Hits         12838    12840    +2     
  Misses        2006     2006           
+ Partials      1289     1288    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru merged commit aa64bb7 into XRPLF:develop Oct 8, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants