Skip to content

Conversation

@emreariyurek
Copy link
Contributor

Fix #1854

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.56%. Comparing base (a4b47da) to head (ad3a050).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/handlers/LedgerEntry.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2654      +/-   ##
===========================================
- Coverage    79.57%   79.56%   -0.01%     
===========================================
  Files          385      385              
  Lines        16141    16153      +12     
  Branches      8453     8459       +6     
===========================================
+ Hits         12844    12852       +8     
- Misses        2007     2012       +5     
+ Partials      1290     1289       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@mathbunnyru mathbunnyru merged commit b361e3a into XRPLF:develop Oct 14, 2025
54 of 55 checks passed
@emreariyurek emreariyurek deleted the emre_1854_new_type_ledger_entry branch October 18, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New type supported by ledger_entry

4 participants