Skip to content

Conversation

@kuznetsss
Copy link
Collaborator

Fixes #2350.

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.96%. Comparing base (b8c298b) to head (e5d97fe).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2505   +/-   ##
========================================
  Coverage    79.95%   79.96%           
========================================
  Files          384      384           
  Lines        15918    15919    +1     
  Branches      8328     8329    +1     
========================================
+ Hits         12728    12729    +1     
  Misses        1912     1912           
  Partials      1278     1278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

PeterChen13579
PeterChen13579 previously approved these changes Sep 3, 2025
Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuznetsss kuznetsss merged commit 26ef25f into XRPLF:develop Sep 4, 2025
30 checks passed
@kuznetsss kuznetsss deleted the 2350_Add_network_id_to_ledger_stream branch September 4, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add network_id to subscriptions output

3 participants