chore: Move config definition to cpp file #2371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This also allows to use ClioConfigDefinition when constructing other globals. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2371 +/- ##
===========================================
+ Coverage 79.43% 79.51% +0.08%
===========================================
Files 380 380
Lines 15412 15500 +88
Branches 7760 7817 +57
===========================================
+ Hits 12242 12325 +83
- Misses 1972 1974 +2
- Partials 1198 1201 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
godexsoft
approved these changes
Jul 28, 2025
Collaborator
godexsoft
left a comment
There was a problem hiding this comment.
Alright 👍 Let's see if @kuznetsss and @PeterChen13579 are happy with this as well.
kuznetsss
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having such a long init list in almost every translation unit is definitely not nice.
It makes it more difficult to work on custom logger (because I need to adjust log_format), so let's move it to cpp file