Skip to content

Conversation

@mathbunnyru
Copy link
Collaborator

No description provided.

@kuznetsss
Copy link
Collaborator

Would it be possible to specify this docker image in one place and reuse it everywhere to avoid changing 12 files each time we update docker?

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.39%. Comparing base (00333a8) to head (11783f6).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2354      +/-   ##
===========================================
- Coverage    79.41%   79.39%   -0.02%     
===========================================
  Files          378      378              
  Lines        15387    15387              
  Branches      7753     7753              
===========================================
- Hits         12219    12217       -2     
- Misses        1972     1974       +2     
  Partials      1196     1196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru
Copy link
Collaborator Author

Would it be possible to specify this docker image in one place and reuse it everywhere to avoid changing 12 files each time we update docker?

I thought about it and asked gemini and don't know a good way.
The problem is we need to define the image before running steps.

  1. We can use variables, but they are stored as part of settings, so won't work for us
  2. We can define a job in each workflow which will print the image in GITHUB_OUTPUT (the version might be stored in a callable workflow or .github/actions), and we will add need statement and use this value. This won't look nice in the UI and in the workflow files too
  3. We can reduce a little bit duplication and define image in env part of each workflow. But the number of files changing will stay the same

If you have other ideas, please let me know, but I don't think there is a really good solution here

@mathbunnyru mathbunnyru merged commit 3f0f20a into XRPLF:develop Jul 22, 2025
150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants