Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (d43002b) to head (eadb8f3).
Report is 1 commits behind head on develop.

@@             Coverage Diff             @@
##           develop    #2333      +/-   ##
===========================================
- Coverage    79.45%   79.45%   -0.01%     
===========================================
  Files          378      378              
  Lines        15373    15375       +2     
  Branches      7748     7749       +1     
===========================================
+ Hits         12215    12216       +1     
  Misses        1962     1962              
- Partials      1196     1197       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The bug was happening because result and timer were accessed for writing when they are already destroyed. But this only happens when multiple coroutines are accessing the cache simultaneously with the right timing. I don't think we can reproduce this in test.

I agree with @mathbunnyru that it would be nice to add a test for this fix. But i also recall it was not very easy to even reproduce, right?

@kuznetsss could you please answer here?
Just for the history, why we're not adding the test

I already answered:

I don't think we can reproduce this in test.