feat: Read-write switching in ETLng #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2199 +/- ##
===========================================
- Coverage 73.26% 73.23% -0.03%
===========================================
Files 368 370 +2
Lines 14977 15082 +105
Branches 7595 7656 +61
===========================================
+ Hits 10973 11046 +73
- Misses 1898 1914 +16
- Partials 2106 2122 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kuznetsss
reviewed
Jun 10, 2025
mathbunnyru
requested changes
Jun 10, 2025
mathbunnyru
requested changes
Jun 10, 2025
mathbunnyru
requested changes
Jun 10, 2025
mathbunnyru
requested changes
Jun 11, 2025
mathbunnyru
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1597
This PR implements a mechanism for multiple ETL nodes to coordinate who is the writer at any given point.
The mechanism is mirroring the previous ETL's implementation relying on database conflict on write and monitoring the DB for newly added ledgers. Inactivity is detected after certain delay which triggers the node to attempt and become a writer.
This should be the last PR needed for the complete Loader implementation