style: Beautify installation lists in Dockerfile #2172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godexsoft
previously approved these changes
Jun 2, 2025
kuznetsss
approved these changes
Jun 2, 2025
legleux
reviewed
Jun 23, 2025
Comment on lines
+32
to
+51
| && apt install -y --no-install-recommends --no-install-suggests \ | ||
| bison \ | ||
| clang-tidy-${LLVM_TOOLS_VERSION} \ | ||
| clang-tools-${LLVM_TOOLS_VERSION} \ | ||
| flex \ | ||
| git \ | ||
| git-lfs \ | ||
| graphviz \ | ||
| jq \ | ||
| make \ | ||
| ninja-build \ | ||
| python3 \ | ||
| python3-pip \ | ||
| zip \ | ||
| && pip3 install -q --upgrade --no-cache-dir pip \ | ||
| && pip3 install -q --no-cache-dir \ | ||
| cmake==3.31.6 \ | ||
| conan==1.62 \ | ||
| gcovr \ | ||
| pre-commit \ |
Collaborator
There was a problem hiding this comment.
You can use heredocs in Dockerfiles now (can write to a file also).
You might think it's hideous but...
Since you're using bash you could use an array to comment why you're adding these tools also:
RUN <<EOF
pkgs=()
pkgs+=(build-essential) # required build tools
...
pkgs+=(jq) # pretty printing
pkgs+=(python3-pip python-is-python3) # Python and pip for Conan (and CMake)
...
apt-get update && apt-get install --yes "${pkgs[@]}"
EOFMaybe can lose the && with
SHELL ["/bin/bash", "-o", "pipefail", "-o", "errexit", "-c"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.