feat: Support Permissioned DEX #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
335327f to
2636746
Compare
f6d6c3a to
42ae227
Compare
mathbunnyru
commented
May 23, 2025
Collaborator
Author
|
@shawnxie999 could you please take a look at this PR? This is my first PR to support new rippled feature, so I might be doing something wrong, so please, be as thorough as possible. |
shawnxie999
reviewed
May 23, 2025
mathbunnyru
commented
May 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2152 +/- ##
===========================================
- Coverage 73.31% 73.27% -0.04%
===========================================
Files 368 368
Lines 14958 14977 +19
Branches 7587 7595 +8
===========================================
+ Hits 10966 10975 +9
- Misses 1890 1897 +7
- Partials 2102 2105 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
godexsoft
previously approved these changes
May 30, 2025
Collaborator
godexsoft
left a comment
There was a problem hiding this comment.
Nicely done 👍 I left a few suggestions but nothing that could not be ignored.
shawnxie999
previously approved these changes
May 30, 2025
Collaborator
shawnxie999
left a comment
There was a problem hiding this comment.
Looks good! Congratulations on your first feature PR! 🔥
godexsoft
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #2143
Will add tests