Skip to content

Conversation

@godexsoft
Copy link
Collaborator

This PR ports MPT-related ETL functionality into ETLng.

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.21%. Comparing base (3e83b54) to head (0f066aa).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/etlng/impl/ext/MPT.cpp 78.26% 0 Missing and 5 partials ⚠️
src/etl/ETLService.cpp 0.00% 2 Missing ⚠️
src/etlng/impl/ext/NFT.cpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2154      +/-   ##
===========================================
+ Coverage    73.14%   73.21%   +0.07%     
===========================================
  Files          365      366       +1     
  Lines        14870    14895      +25     
  Branches      7554     7567      +13     
===========================================
+ Hits         10876    10905      +29     
+ Misses        1897     1885      -12     
- Partials      2097     2105       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking

mathbunnyru
mathbunnyru previously approved these changes May 23, 2025
kuznetsss
kuznetsss previously approved these changes May 23, 2025
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shawnxie999
shawnxie999 previously approved these changes May 23, 2025
Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New logic looks good from my end. One small nit you may decide at your discretion

@godexsoft godexsoft dismissed stale reviews from shawnxie999, kuznetsss, and mathbunnyru via e829689 May 27, 2025 11:45
@godexsoft godexsoft enabled auto-merge (squash) May 27, 2025 12:04
@godexsoft godexsoft merged commit 2806249 into XRPLF:develop May 27, 2025
28 checks passed
PeterChen13579 pushed a commit to PeterChen13579/clio that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants