Skip to content

refactor: Load balancer forwarding metrics #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mathbunnyru merged 11 commits into from
May 14, 2025
Merged

refactor: Load balancer forwarding metrics #2103

mathbunnyru merged 11 commits into from
May 14, 2025

Conversation

@mathbunnyru
Copy link
Collaborator

@mathbunnyru mathbunnyru commented May 12, 2025

No description provided.

@mathbunnyru
Copy link
Collaborator Author

mathbunnyru commented May 12, 2025

Will add tests a bit later.

@godexsoft @kuznetsss what's the best way to go about forwarding requests?

  1. Duration Histogram vs Counter
  2. No matter success/failure vs Separate them in different metrics

@codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.07%. Comparing base (2d52966) to head (55b3a3e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/etl/LoadBalancer.cpp 90.47% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2103      +/-   ##
===========================================
- Coverage    73.07%   73.07%   -0.01%     
===========================================
  Files          360      360              
  Lines        14805    14812       +7     
  Branches      7518     7523       +5     
===========================================
+ Hits         10819    10824       +5     
  Misses        1948     1948              
- Partials      2038     2040       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

godexsoft
godexsoft reviewed May 13, 2025
View reviewed changes
@mathbunnyru mathbunnyru changed the title fix: Improve load balancer forwarding metrics refactor: Load balancer forwarding metrics May 13, 2025
kuznetsss
kuznetsss approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mathbunnyru mathbunnyru merged commit 243e174 into XRPLF:develop May 14, 2025
29 checks passed
@kuznetsss kuznetsss mentioned this pull request May 15, 2025
Merged
kuznetsss added a commit that referenced this pull request May 15, 2025
@kuznetsss
feat: Forwarding metrics (#2128)
317b3e2 
Port of #2096 and #2103 into `release/2.4.1`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godexsoft godexsoft godexsoft left review comments

@kuznetsss kuznetsss kuznetsss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mathbunnyru @godexsoft @kuznetsss