-
Notifications
You must be signed in to change notification settings - Fork 76
style: Use codespell instead of typos pre-commit hook
#2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why do we need both typos and codespell? I thought the idea of typos was that it ignores unknown words, so we don't have to maintain a big list of exceptions. While for codespell we have to maintain a list of exceptions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2104 +/- ##
===========================================
+ Coverage 72.82% 73.06% +0.24%
===========================================
Files 357 360 +3
Lines 14729 14805 +76
Branches 7479 7518 +39
===========================================
+ Hits 10726 10818 +92
+ Misses 1976 1950 -26
- Partials 2027 2037 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I am adding codespell, because apparently typos is not fixing all the problems present in the codespell. I'm pretty sure it's true the other way around as well. We actually maintain similar list for typos as well: https://github.com/XRPLF/clio/blob/develop/_typos.toml And, it's not that big :) |
codespell instead of typos pre-commit hook
kuznetsss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.