Skip to content

Conversation

@mathbunnyru
Copy link
Collaborator

No description provided.

@kuznetsss
Copy link
Collaborator

kuznetsss commented May 12, 2025

Why do we need both typos and codespell? I thought the idea of typos was that it ignores unknown words, so we don't have to maintain a big list of exceptions. While for codespell we have to maintain a list of exceptions.

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.06%. Comparing base (d02da5d) to head (f47d6bd).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2104      +/-   ##
===========================================
+ Coverage    72.82%   73.06%   +0.24%     
===========================================
  Files          357      360       +3     
  Lines        14729    14805      +76     
  Branches      7479     7518      +39     
===========================================
+ Hits         10726    10818      +92     
+ Misses        1976     1950      -26     
- Partials      2027     2037      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru
Copy link
Collaborator Author

Why do we need both typos and codespell? I thought the idea of typos was that it ignores unknown words, so we don't have to maintain a big list of exceptions. While for codespell we have to maintain a list of exceptions.

I am adding codespell, because apparently typos is not fixing all the problems present in the codespell. I'm pretty sure it's true the other way around as well.

We actually maintain similar list for typos as well: https://github.com/XRPLF/clio/blob/develop/_typos.toml

And, it's not that big :)

@mathbunnyru mathbunnyru changed the title style: Add codespell pre-commit hook style: Use codespell instead of typos pre-commit hook May 13, 2025
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mathbunnyru mathbunnyru merged commit 02ccbf8 into XRPLF:develop May 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants