Skip to content

test: Remove SetUp and TearDown methods in tests #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mathbunnyru merged 1 commit into from
May 7, 2025
Merged

test: Remove SetUp and TearDown methods in tests #2086

mathbunnyru merged 1 commit into from
May 7, 2025

Conversation

@mathbunnyru
Copy link
Collaborator

@mathbunnyru mathbunnyru commented May 6, 2025 •
edited
Loading

Fix: #910

mathbunnyru
mathbunnyru commented May 6, 2025
View reviewed changes
@mathbunnyru
Copy link
Collaborator Author

mathbunnyru commented May 6, 2025 •
edited
Loading

I checked the repo and there are no more TearDown.
One SetUp is needed though:

tests/integration/migration/cassandra/CassandraMigrationManagerTests.cpp:
   90      // This function is used to prepare the database before running the tests
   91:     // It is called in the SetUp function. Different tests can override this function to prepare the database
   92      // differently

  152      void
  153:     SetUp() override
  154      {
  155          setupDatabase();
  156      }

And setupDatabase() is a virtual method of the class, so we shouldn't call it directly in ctor, so I left this one as is.

@codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.74%. Comparing base (9af36e5) to head (b78d7de).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2086      +/-   ##
===========================================
- Coverage    72.76%   72.74%   -0.03%     
===========================================
  Files          355      355              
  Lines        14697    14697              
  Branches      7464     7464              
===========================================
- Hits         10695    10692       -3     
- Misses        1977     1978       +1     
- Partials      2025     2027       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

godexsoft
godexsoft approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@mathbunnyru mathbunnyru merged commit 5e43c3b into XRPLF:develop May 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godexsoft godexsoft godexsoft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove SetUp and TearDown from tests

2 participants

@mathbunnyru @godexsoft