Add headers for building with gcc-12 #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natenichols
reviewed
Jun 29, 2022
Contributor
natenichols
left a comment
There was a problem hiding this comment.
According to slack, you said we also had to add to WorkQueue? Do you still have to do that?
diff --git a/src/main/impl/Build.cpp b/src/main/impl/Build.cpp
index ebb9842..3c13a3f 100644
--- a/src/main/impl/Build.cpp
+++ b/src/main/impl/Build.cpp
@@ -2,6 +2,8 @@
#include <boost/preprocessor/stringize.hpp>
#include <algorithm>
#include <main/Build.h>
+#include <optional>
+#include <stdexcept>
namespace Build {
diff --git a/src/rpc/WorkQueue.h b/src/rpc/WorkQueue.h
index 236dd9a..4a29208 100644
--- a/src/rpc/WorkQueue.h
+++ b/src/rpc/WorkQueue.h
@@ -10,6 +10,7 @@
#include <queue>
#include <shared_mutex>
#include <thread>
+#include <optional>
class WorkQueue
{
Collaborator
Author
yes, that's needed also. I screwed up after clang-format ing. |
Merged
Contributor
|
I lied, its already in WorkQueue.h https://github.com/XRPLF/clio/blob/develop/src/rpc/WorkQueue.h/#L10 |
natenichols
approved these changes
Jun 29, 2022
Contributor
natenichols
left a comment
There was a problem hiding this comment.
Can you sign your commit so we can merge this?
Signed-off-by: Michael Legleux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to add this to build with gcc-12