Skip to content

Conversation

@kuznetsss
Copy link
Collaborator

Fixes #1982.

@kuznetsss kuznetsss requested a review from Copilot April 1, 2025 13:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR pins the CMake version to 3.31.6 on macOS runners to ensure consistent builds.

  • Removes cmake from the default brew install list
  • Adds a step to uninstall any existing cmake and install a specific version from a hard-coded formula URL with checksum verification
  • Ensures Linux runners retain their existing git permissions fix

@kuznetsss kuznetsss requested a review from godexsoft April 1, 2025 13:38
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (427ba47) to head (7dd91c8).
Report is 38 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1983      +/-   ##
===========================================
+ Coverage    72.71%   73.34%   +0.63%     
===========================================
  Files          333      343      +10     
  Lines        13525    14071     +546     
  Branches      6881     7151     +270     
===========================================
+ Hits          9835    10321     +486     
- Misses        1785     1807      +22     
- Partials      1905     1943      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuznetsss kuznetsss merged commit 60df3a1 into XRPLF:develop Apr 1, 2025
22 checks passed
@kuznetsss kuznetsss deleted the 1982_Fix_nightly_build branch April 1, 2025 13:49
PeterChen13579 pushed a commit to maria-robobug/clio that referenced this pull request Apr 9, 2025
kuznetsss added a commit to kuznetsss/clio that referenced this pull request May 14, 2025
@kuznetsss kuznetsss restored the 1982_Fix_nightly_build branch September 4, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly release failed 🌙

2 participants