Skip to content

fix: Fix url check in config #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kuznetsss merged 1 commit into from
Mar 11, 2025
Merged

fix: Fix url check in config #1953

kuznetsss merged 1 commit into from
Mar 11, 2025

Conversation

@kuznetsss
Copy link
Collaborator

@kuznetsss kuznetsss commented Mar 11, 2025

Fixes #1850

@kuznetsss kuznetsss requested a review from godexsoft March 11, 2025 11:57
@codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.19%. Comparing base (427ba47) to head (6cae191).
Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/newconfig/ConfigConstraints.cpp 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1953      +/-   ##
===========================================
+ Coverage    72.71%   73.19%   +0.47%     
===========================================
  Files          333      338       +5     
  Lines        13525    13853     +328     
  Branches      6881     7022     +141     
===========================================
+ Hits          9835    10140     +305     
- Misses        1785     1787       +2     
- Partials      1905     1926      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuznetsss kuznetsss merged commit 2684237 into XRPLF:develop Mar 11, 2025
22 checks passed
@kuznetsss kuznetsss deleted the 1850_Allow_urls_in_config branch March 11, 2025 12:54
@kuznetsss kuznetsss restored the 1850_Allow_urls_in_config branch September 4, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godexsoft godexsoft godexsoft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow urls in config

2 participants

@kuznetsss @godexsoft