feat: Implement and use LedgerCacheInterface #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1955 +/- ##
===========================================
+ Coverage 73.18% 73.20% +0.01%
===========================================
Files 338 339 +1
Lines 13853 13859 +6
Branches 7022 7023 +1
===========================================
+ Hits 10139 10145 +6
- Misses 1789 1790 +1
+ Partials 1925 1924 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kuznetsss
reviewed
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1200
This PR introduces
LedgerCacheInterfaceand modifies the rest of the codebase to use cache (mostly) through this interface.Removal of
cache()getters inBackendInterfacewill be done after old ETL code is removed.