fix: CacheLoader causes crash when no cache is used #1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godexsoft
approved these changes
Jan 28, 2025
Collaborator
godexsoft
left a comment
There was a problem hiding this comment.
Nice! Thanks for fixing this 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1853 +/- ##
===========================================
+ Coverage 71.61% 71.63% +0.02%
===========================================
Files 330 330
Lines 13411 13413 +2
Branches 6824 6826 +2
===========================================
+ Hits 9604 9609 +5
+ Misses 1923 1920 -3
Partials 1884 1884 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If cache is disabled or Clio starts with and empty DB,
loader_inside cache is not created. So callingCacheLoader::stop()orCacheLoader::wait()was causing crash.