Skip to content

Conversation

@godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented Dec 8, 2024

Fix #1664

Adds a few useful checks and fixes the code to accommodate them.
modernize-use-ranges seems to work with a few modifications to the code and exceptions for the linter.

@godexsoft godexsoft marked this pull request as draft December 8, 2024 04:03
@codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 43.24324% with 84 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (a7074db) to head (067c817).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/common/impl/HandlerProvider.cpp 0.00% 35 Missing ⚠️
src/rpc/common/Validators.hpp 5.88% 0 Missing and 16 partials ⚠️
src/rpc/common/Modifiers.hpp 0.00% 0 Missing and 8 partials ⚠️
src/etl/MPTHelpers.cpp 0.00% 4 Missing ⚠️
src/etl/NFTHelpers.cpp 55.55% 4 Missing ⚠️
src/etl/impl/CursorFromFixDiffNumProvider.hpp 0.00% 0 Missing and 3 partials ⚠️
src/data/LedgerCache.cpp 33.33% 2 Missing ⚠️
src/etl/impl/Transformer.hpp 0.00% 2 Missing ⚠️
src/rpc/RPCEngine.hpp 66.66% 1 Missing and 1 partial ⚠️
src/rpc/RPCHelpers.cpp 83.33% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1774      +/-   ##
===========================================
- Coverage    71.70%   71.67%   -0.03%     
===========================================
  Files          295      295              
  Lines        12679    12679              
  Branches      6500     6499       -1     
===========================================
- Hits          9091     9088       -3     
- Misses        1873     1874       +1     
- Partials      1715     1717       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godexsoft godexsoft marked this pull request as ready for review December 9, 2024 11:34
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@godexsoft godexsoft merged commit 475e309 into XRPLF:develop Dec 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update tools to LLVM 19.1

3 participants