Skip to content

Conversation

@cindyyan317
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (11192c3) to head (88eec60).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/web/impl/WsBase.hpp 50.00% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1691   +/-   ##
========================================
  Coverage    70.33%   70.34%           
========================================
  Files          266      266           
  Lines        10182    10191    +9     
  Branches      5618     5621    +3     
========================================
+ Hits          7162     7169    +7     
+ Misses        1543     1542    -1     
- Partials      1477     1480    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cindyyan317 cindyyan317 merged commit 9b0b4f5 into XRPLF:develop Oct 16, 2024
@cindyyan317 cindyyan317 deleted the add_message_counter branch October 16, 2024 16:06
kuznetsss pushed a commit to kuznetsss/clio that referenced this pull request Oct 17, 2024
kuznetsss pushed a commit to kuznetsss/clio that referenced this pull request Oct 17, 2024
kuznetsss pushed a commit to kuznetsss/clio that referenced this pull request Oct 17, 2024
PeterChen13579 pushed a commit to PeterChen13579/clio that referenced this pull request Oct 17, 2024
void
onWrite(boost::system::error_code ec, std::size_t)
{
LOG(perfLog_.info()) << tag() << "xinmeng sent message";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cindyyan317 was this intended to be included in the PR here? seems a bit user specific 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi That was a mistake. Thanks for pointing it out. Will remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants