Skip to content

feat: Move/copy support in async framework #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godexsoft merged 9 commits into from
Aug 20, 2024
Merged

feat: Move/copy support in async framework #1609

godexsoft merged 9 commits into from
Aug 20, 2024

Conversation

@godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented Aug 15, 2024

Fixes #1608

@codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.16667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.86%. Comparing base (fb473f6) to head (0ac2e39).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/util/async/AnyExecutionContext.hpp 60.00% 0 Missing and 6 partials ⚠️
src/util/async/context/impl/Execution.hpp 0.00% 0 Missing and 2 partials ⚠️
src/util/async/AnyStrand.hpp 66.66% 0 Missing and 1 partial ⚠️
src/util/async/context/BasicExecutionContext.hpp 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1609   +/-   ##
========================================
  Coverage    69.85%   69.86%           
========================================
  Files          260      260           
  Lines         9917     9939   +22     
  Branches      5466     5472    +6     
========================================
+ Hits          6928     6944   +16     
  Misses        1589     1589           
- Partials      1400     1406    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cindyyan317
cindyyan317 reviewed Aug 19, 2024
View reviewed changes
@godexsoft godexsoft force-pushed the feature/async_framework_immovability branch from 88608ab to 7c2a1a8 Compare August 19, 2024 13:38
kuznetsss
kuznetsss reviewed Aug 19, 2024
View reviewed changes
cindyyan317
cindyyan317 reviewed Aug 20, 2024
View reviewed changes
cindyyan317
cindyyan317 reviewed Aug 20, 2024
View reviewed changes
@godexsoft godexsoft marked this pull request as ready for review August 20, 2024 12:11
kuznetsss
kuznetsss approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cindyyan317
cindyyan317 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@godexsoft godexsoft merged commit 9a9de50 into XRPLF:develop Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuznetsss kuznetsss kuznetsss approved these changes

+1 more reviewer

@cindyyan317 cindyyan317 cindyyan317 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix AsyncFramework's immovability

3 participants

@godexsoft @kuznetsss @cindyyan317