fix minor codecov

XRPLF · PeterChen13579 · Aug 6, 2024 · Jul 15, 2024 · Jul 15, 2024 · Jul 15, 2024
commit ce51e8569afeda0aa7fe52bd11a20fb0aa94998c
diff --git a/src/util/newconfig/ConfigDefinition.hpp b/src/util/newconfig/ConfigDefinition.hpp
@@ -92,10 +92,8 @@ struct ClioConfigDescription {
         auto const itr = std::find_if(configDescription.begin(), configDescription.end(), [&key](auto const& v) {
             return v.key == key;
         });
-        if (itr != configDescription.end()) {
-            return itr->value;
-        }
-        return "Not Found";
+        ASSERT(itr != configDescription.end(), "key doesn't exist in config");
+        return itr->value;
     }
 
 private:

diff --git a/src/util/newconfig/ObjectView.hpp b/src/util/newconfig/ObjectView.hpp
@@ -67,15 +67,6 @@ class ObjectView {
     bool
     containsKey(std::string_view key) const;
 
-    /**
-     * @brief Checks if any key in ClioConfigDefinition starts with prefix_.key
-     *
-     * @param key The suffix of the key
-     * @return true if at least one key starts with the specified prefix_.key, otherwise false
-     */
-    bool
-    startsWithKey(std::string_view key) const;
-
     /**
      * @brief Retrieves the value associated with the specified prefix._key in ClioConfigDefinition
      *
@@ -105,6 +96,15 @@ class ObjectView {
     std::string
     getFullKey(std::string_view key) const;
 
+    /**
+     * @brief Checks if any key in ClioConfigDefinition starts with prefix_.key
+     *
+     * @param key The suffix of the key
+     * @return true if at least one key starts with the specified prefix_.key, otherwise false
+     */
+    bool
+    startsWithKey(std::string_view key) const;
+
     std::string prefix_;
     std::optional<size_t> arrayIndex_;
     ClioConfigDefinition const& clioConfig_;