Skip to content

feat: Ledger index #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cindyyan317 merged 3 commits into from
Jul 2, 2024
Merged

feat: Ledger index #1503

cindyyan317 merged 3 commits into from
Jul 2, 2024

Conversation

@cindyyan317
Copy link
Contributor

@cindyyan317 cindyyan317 commented Jun 28, 2024

#1052

Feature ledger_index

Return the latest closed ledger index before the given date.
Without any database change, this PR binary search from valid range.
For the full history node, the range is less than 9,000,000 now. The O(n) -> logN should be 27. Comparing with other handlers, it is acceptable.

Example input:

{
 "method": "ledger_index",
 "params": [
     {
       "date":"2024-06-20T09:00:42.000Z"
     }
   ]
}

Example output:

{
  "result":
    {
      "ledger_index": 88816562,
      "ledger_hash": "63911F91F399EFC29E97041477D41B0454159B82EBF0C0223CBE021D89A81D70",
      "closed": "2024-06-20T09:00:42.000Z"
    }
}

@codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.15%. Comparing base (d26c93a) to head (243929b).

Files Patch % Lines
src/rpc/handlers/LedgerIndex.hpp 60.00% 0 Missing and 2 partials ⚠️
src/rpc/common/impl/HandlerProvider.cpp 0.00% 1 Missing ⚠️
src/rpc/handlers/LedgerIndex.cpp 97.72% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1503      +/-   ##
===========================================
+ Coverage    67.98%   68.15%   +0.16%     
===========================================
  Files          234      236       +2     
  Lines         9490     9552      +62     
  Branches      5275     5303      +28     
===========================================
+ Hits          6452     6510      +58     
- Misses        1656     1657       +1     
- Partials      1382     1385       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

godexsoft
godexsoft requested changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Leaving a few comments and nits 👍

@cindyyan317 cindyyan317 requested a review from godexsoft July 1, 2024 15:12
godexsoft
godexsoft previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I'm leaving a few questions, feel free to ignore as it already works as is anyway 🚀

@godexsoft godexsoft self-requested a review July 2, 2024 12:50
godexsoft
godexsoft approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@cindyyan317 cindyyan317 merged commit 6684943 into XRPLF:develop Jul 2, 2024
This was referenced Jul 12, 2024
Open
Open
@mDuo13 mDuo13 mentioned this pull request Jul 31, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godexsoft godexsoft godexsoft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cindyyan317 @godexsoft