ビルドテストをプルリクエスト時にも行うようにする #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM! |
Hiroshiba
approved these changes
Mar 22, 2022
Member
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！
そろそろcpp-libraryをmainにマージしてもいいかなと思うのですが、どうでしょう👀
（ためしにプルリク化しようとしたらコンフリクトが発生していそうでした）
Member
Author
こちらで対応してみます...! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
題の通りです。
その他
マージしてから、ビルドが回らないことに気づくと言ったことを防ぎたく、本PRを作成しました。
後に、関数テストとかもこの中で回せると良いのかなと思いました。