Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 28, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
Rust minor 1.74.1 -> 1.75.0

Release Notes

rust-lang/rust (Rust)

v1.75.0

Compare Source

==========================

Language

Compiler

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Rustdoc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@qryxip
Copy link
Member

qryxip commented Dec 29, 2023

加えた変更: 560557a (#716)
(コミットメッセージ本文参照)

@qryxip qryxip requested a review from Hiroshiba December 29, 2023 02:17
fn string_feature_by_regex(re: &Regex, label: &str) -> std::result::Result<String, ErrorKind> {
if let Some(caps) = re.captures(label) {
Ok(caps.get(2).unwrap().as_str().to_string())
Ok(caps[2].to_string())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regex::Captures_.get(i).unwrap()_[i]が返すものが異なる。
(_.get(i).unwrap().to_str()_[i]が同じ)

`x.get(i).unwrap()`としているところを、すべて`x[i]`にする。
`clippy::get_first`が`.get(0).unwrap()`という表現を咎めるようになった
ことへの対応であるが、他の`.get(_).unwrap()`もそんなに数が無いので
この際に一括で置き換えてしまうことにする。
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よくわかってないですがとりあえずLGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants