branch <- main #103
Merged
branch <- main #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add errors ignore so it doesn't default to error raise (failing). THis change is needed because a new result has bad units (percent for secchi depth...). * Ignore pH errors (e.g., mV). This can be reverted if functionality is added in the future (see issue #102)
jbousquin
added a commit
that referenced
this pull request
Oct 31, 2024
* Create CITATION.cff Add JOSS citation * Update README.md Add JOSS badge/link to paper * Add errors ignore so it doesn't default to error raise (failing). (#101) (#103) * Add errors ignore so it doesn't default to error raise (failing). THis change is needed because a new result has bad units (percent for secchi depth...). * Ignore pH errors (e.g., mV). This can be reverted if functionality is added in the future (see issue #102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add errors ignore so it doesn't default to error raise (failing). THis change is needed because a new result has bad units (percent for secchi depth...).
Ignore pH errors (e.g., mV). This can be reverted if functionality is added in the future (see issue pH measured in mV #102)