Pump efficiency curve treated like other curves #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 10, 2025 17:16
kaklise
approved these changes
Aug 25, 2025
Collaborator
kaklise
left a comment
There was a problem hiding this comment.
Thanks for adding this update to WNTR. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using pump.efficiency doesn't use the curve registry, and doesn't round trip on to_dict/from_dict.
See #517
This deprecates pump.efficiency and creates pump.efficiency_curve and pump.efficiency_cure_name, which work in a similar way to other curves.
Tests and documentation
Added to_dict / from_dict round trip test for efficiency
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.