Model development demo #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to geospatial to get elevations from nearest neighbors when elevation data is missing Added demonstration geojson files with KY4 misaligned pipes and decimated junction list.
Network gen updates
Merge main into network gen branch
Updates to the model development notebook
Model Dev NB Updates
Network gen blurb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new demo that creates a water network model using imperfect geospatial data
Summary
This PR includes the following updates
model_development.ipynbthat builds a water network model using imperfect geospatial data using files based on ky4connect_linesfunction to connect geospatial lines that do not share endpoints. Line end points are connected if they fall within a user specified distance threshold. The function uses spipy linkage and fcluster.add_controlto add a controls from a string in EPANET format (for example, "LINK Pump-1 OPEN IF NODE Tank-1 BELOW 10")from_dictto include 0 as the default value for elevationTests and documentation
New documentation and test were added for the
connect_linefunction.Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.