feat: implement get_alignment for BasicType trait #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisianArchitect
approved these changes
Dec 8, 2025
Contributor
ErisianArchitect
left a comment
There was a problem hiding this comment.
This code looks good to me.
Owner
|
If the method also exists on all individual variants of BasicType/Enum, we should remove them in favor of the trait impl |
Contributor
Author
I've removed the individual get_alignment implementations from specific types (IntType, FloatType, etc.) in favor of the default implementation in the BasicType trait. |
Contributor
Author
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
get_alignmentmethod in theBasicTypetrait by utilizing the underlyingType::get_alignmentimplementation.Previously,
get_alignmentwas only available on specific types (likeIntType,StructType) but not accessible via theBasicTypetrait orBasicTypeEnum. This change aligns the behavior withsize_of, allowing generic usage of alignment retrieval.Related Issue
N/A (This fixes a minor missing feature where
get_alignmentwas absent from theBasicTypetrait).How This Has Been Tested
I have verified the changes by running existing tests and adding a specific assertion to the
test_basic_type_enumtest case.cargo test --features "llvm20-1"(passed)tests/all/test_types.rsto ensureBasicTypeEnum::get_alignmentreturns the correct value matching the underlying type.Checklist