Skip to content

docs: update Chinese glsl-extension documentation #6162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nihui merged 1 commit into from
Jul 10, 2025
Merged

docs: update Chinese glsl-extension documentation #6162

nihui merged 1 commit into from
Jul 10, 2025

Conversation

@chri321
Copy link
Contributor

@chri321 chri321 commented Jul 10, 2025

更新 GLSL 扩展中文文档
Fixes #6135

变更内容

  1. 完整同步英文文档最新内容至中文版
  2. 修正英文文档拼写错误：
    • ncnn_enable_validataion_layer → ncnn_enable_validation_layer
  3. 移除中文文档的条件编译指令，英文文档中已经删除，保持一致： 
    #if NCNN_fp16_storage
#extension GL_EXT_shader_16bit_storage: require
#endif
#if NCNN_fp16_arithmetic
#extension GL_EXT_shader_explicit_arithmetic_types_float16: require
#endif

@github-actions github-actions bot added the doc label Jul 10, 2025
@tencent-adm
Copy link
Member

tencent-adm commented Jul 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nihui
Copy link
Member

nihui commented Jul 10, 2025

既然修好了拼写，那么

ncnn/src/gpu.cpp

Line 5298 in cae9e63

device_defines.append("enable_validataion_layer", VK_TRUE);
这里的也要一起修改下

@github-actions
Copy link

github-actions bot commented Jul 10, 2025

The binary size change of libncnn.so (bytes)

architecture base size pr size difference
x86_64 15653296 15653296 0 😘
armhf 6653768 6653768 0 😘
aarch64 9989696 9989696 0 😘

@chri321
docs: update Chinese glsl-extension documentation
79a1120 
- synchronize the latest English content to the Chinese documentation
- correct spelling errors in the English version of glsl-extention
- Fix spelling 'enable_validation_layer' in src/gpu.cpp
@chri321 chri321 force-pushed the update-doc-glsl-extension-zh branch from e87a054 to 79a1120 Compare July 10, 2025 03:20
@github-actions github-actions bot added the core label Jul 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (171b9d1) to head (79a1120).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6162      +/-   ##
==========================================
- Coverage   95.82%   95.59%   -0.23%     
==========================================
  Files         834      743      -91     
  Lines      265366   245693   -19673     
==========================================
- Hits       254277   234875   -19402     
+ Misses      11089    10818     -271

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chri321
Copy link
Contributor Author

chri321 commented Jul 10, 2025

感谢！已经修改 src/gpu.cpp 中的 “enable_validataion_layer”

@nihui nihui merged commit 4c72f52 into Tencent:master Jul 10, 2025
100 of 104 checks passed
@nihui
Copy link
Member

nihui commented Jul 10, 2025

Thanks for your contribution !

@nihui nihui mentioned this pull request Jul 10, 2025
Closed
@BrewTestBot BrewTestBot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nihui nihui nihui approved these changes

Assignees

No one assigned

Labels

core doc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update glsl extension zh doc

4 participants

@chri321 @tencent-adm @nihui @codecov-commenter