packages/go/slicesext/slicesext_test.go (4)

35-35: Fix typo in suite name.

Change “Intergration” → “Integration”.

- r := runner.NewRunner(t, "BHCE: Intergration Tests")
+ r := runner.NewRunner(t, "BHCE: Integration Tests")

If the goal is to get results into Allure in CI, ensure ALLURE_OUTPUT_FOLDER/ALLURE_OUTPUT_PATH are set so results are written where your pipeline expects them. (github.com)

---

37-43: Don’t pass a third arg to NewTest; tag inside the test with t.Tags().

Project docs show NewTest(name, func(t provider.T)) (no extra args); use t.Tags(...) to add labels. (github.com)

- r.NewTest("Test IsOdd function", func(t provider.T) {
+ r.NewTest("Test IsOdd function", func(t provider.T) {
     t.Title("Test isOdd function")
     t.Description("check odd nums")
     t.Severity(allure.CRITICAL)
+    t.Tags("isOdd")
     t.Require().Equal([]int{1, 3}, slicesext.Filter([]int{1, 2, 3, 4}, isOdd))
- }, "Tag @ Test Level: isOdd")
+ })

---

44-50: Same here: move the tag into the body with t.Tags().

- r.NewTest("Test isLong function", func(t provider.T) {
+ r.NewTest("Test isLong function", func(t provider.T) {
     t.Title("Test isLong function")
     t.Description("check for long chars")
     t.Severity(allure.CRITICAL)
+    t.Tags("isLong")
     t.Require().Equal([]string{"bbbbbb", "cccccccc"}, slicesext.Filter([]string{"aaaa", "bbbbbb", "cccccccc", "dd"}, isLong))
- }, "Tag @ Test Level: isLong")
+ })

---

51-51: Optionally capture SuiteResult for future integrations.

r.RunTests() returns a SuiteResult; capturing it can help if you later need to aggregate/append metadata. (github.com)

- r.RunTests()
+ _ = r.RunTests()

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

.gitignore (1)

463-464: Make Allure ignores recursive; consider ignoring generated reports too.

Use a recursive pattern so nested attachments are ignored, and optionally ignore allure-report/ artifacts.

-**/allure-results/*
+**/allure-results/**
+# (optional) ignore generated HTML reports as well
+**/allure-report/**

packages/go/allure.go/suite_manager.go (1)

1-1: Add license header and doc comments for exported symbols.

Keep headers consistent with the repo and add brief docs for SuiteManager to satisfy linters.

+// Copyright 2025 Specter Ops, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
 package allurego

 type SuiteManager struct {
 	suite.Suite
 }
+
+// SuiteManager provides common Allure suite hooks shared by test suites.

packages/go/slicesext/slicesext_test.go (2)

66-81: Fix “not mutated” assertion; current check is ineffective.

NotSame(&in, &out) always passes (different slice variables). Assert the input remains unchanged (and optionally that backing arrays differ).

 	var (
 		in  = []string{"a", "a", "b", "b"}
 		out = slicesext.Unique(in)
 	)
 
-	t.Require().Equal([]string{"a", "b"}, out)
-	t.Require().NotSame(&in, &out) // ensure we didn't mutate the original slice
+	orig := slices.Clone(in)
+	t.Require().Equal([]string{"a", "b"}, out)
+	t.Require().Equal(orig, in) // ensure original slice contents unchanged
 	t.Require().Equal([]string{"a", "b"}, slicesext.Unique([]string{"a", "b", "b", "a"}))
 	t.Require().Equal([]string{"a"}, slicesext.Unique([]string{"a"}))
 	t.Require().Equal([]int{1, 2, 3}, slicesext.Unique([]int{1, 1, 2, 2, 3}))
 
-	s.AfterAll(t)
+	// no manual hook invocation

Optional: also assert different backing arrays using unsafe.SliceData if desired.

---

83-85: Parallel suite runner: verify Allure writer is concurrency-safe.

Running the suite in parallel is great for speed but can interleave writes to allure-results. Confirm the framework merges results safely or set distinct ALLURE_RESULTS_DIR per package in CI.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

packages/go/stbernard/command/alluregen/internal/utils.go (1)

5-10: Fix param typo and simplify SHA-256 hashing.

Minor cleanup; Reset is redundant, and Sum256 is simpler.

Apply this diff:

-func hashString(testtCaseName string) []byte {
-	hash := sha256.New()
-	hash.Reset()
-	hash.Write([]byte(testtCaseName))
-	return hash.Sum(nil)
+func hashString(testCaseName string) []byte {
+	sum := sha256.Sum256([]byte(testCaseName))
+	return sum[:]
}

packages/go/stbernard/command/alluregen/alluregen.go (3)

9-11: Use a distinct import alias to avoid confusion with the current package name.

Clearer to avoid same-name alias as the enclosing package.

Apply this diff:

-	alluregen "github.com/specterops/bloodhound/packages/go/stbernard/command/alluregen/internal"
+	internalcmd "github.com/specterops/bloodhound/packages/go/stbernard/command/alluregen/internal"

---

22-27: Fix copy/paste comment.

Apply this diff:

-// Create a new instance of license command within the current environment
+// Create a new instance of the alluregen command within the current environment

---

55-60: Update call site to match the new alias.

Apply this diff:

-func (c *command) Run() error {
-	if err := alluregen.Run(); err != nil {
+func (c *command) Run() error {
+	if err := internalcmd.Run(); err != nil {
 		return fmt.Errorf("Running alluregen cmd: %w", err)
 	}
 	return nil
 }

packages/go/stbernard/command/alluregen/internal/types.go (1)

56-75: Derive stable IDs and prefer uuid.NewString().

Small cleanup; no behavior change.

Apply this diff:

 	// Create a hash from test case fullname to generate a stateful reporting
 	calTestCaseHash := hashString(e.Test)
 	testCaseUUID := fmt.Sprintf("%x", calTestCaseHash)
 	calHashHistory := hashString(testCaseUUID)
 	historyID := fmt.Sprintf("%x", calHashHistory)
 
 	ts.FullName = e.Test
 	ts.Name = e.Test
-	ts.UUID = uuid.New().String()
+	ts.UUID = uuid.NewString()
 	ts.TestCaseId = testCaseUUID
 	ts.HistoryId = historyID

.github/workflows/run-go-unit-tests.yml (1)

50-57: Pin golurectl to a fixed version and remove UUOC

-      - name: Install AllureCtl
-        run: |
-          go install github.com/robotomize/go-allure/cmd/golurectl@latest
+      - name: Install AllureCtl
+        run: |
+          go install github.com/robotomize/go-allure/cmd/[email protected]  # pin to a specific release

-      - name: Building Allure JSON
-        run: |
-          cat test_results.json | golurectl -l -e --allure-suite "Go Test" --allure-tags "Unit" -o ./allure-results
+      - name: Building Allure JSON
+        run: |
+          golurectl -l -e --allure-suite "Go Test" --allure-tags "Unit" -o ./allure-results < test_results.json

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

.github/workflows/run-go-unit-tests.yml (6)

31-34: Set minimal permissions and add concurrency to cancel superseded runs.

This reduces token scope and avoids duplicate in‑flight runs on the same ref.

 jobs:
   run-tests:
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    concurrency:
+      group: run-go-tests-${{ github.event_name }}-${{ github.ref || github.head_ref }}
+      cancel-in-progress: true

---

46-49: Harden tests: add -race and keep JSON even on failure.

• -race catches data races early.
• tee preserves JSON while keeping output visible.

-          go test -json -cover ./... > test_results.json
+          go test -json -race -cover ./... | tee test_results.json

---

58-65: Scope history checkout to non‑PR events and fetch full history.

Avoids noisy failures on forks and ensures history is available for trends.

       - name: Get Allure history
-        uses: actions/checkout@v4
-        if: always()
+        uses: actions/checkout@v4
+        if: ${{ github.event_name != 'pull_request' && always() }}
         continue-on-error: true
         with:
           ref: gh-pages
           path: gh-pages
+          fetch-depth: 0

---

19-30: Consider handling more PR activity types.

Add reopened and ready_for_review to avoid missing events.

   pull_request:
     branches:
       - main
       - "stage/**"
     types:
       - opened
       - synchronize
+      - reopened
+      - ready_for_review

---

54-56: Nit: avoid UUOC.

You can redirect stdin directly for clarity.

-          cat test_results.json | golurectl -l -e --allure-suite "Go Test" --allure-tags "Unit" -o ./allure-results
+          golurectl -l -e --allure-suite "Go Test" --allure-tags "Unit" -o ./allure-results < test_results.json

---

50-56: Pin golurectl to v0.14.3 and make conversion resilient to test failures

• Add if: always() to install and conversion steps, and skip conversion if test_results.json is missing.
• Pin installation to the latest stable tag (v0.14.3) for reproducibility.

       - name: Install AllureCtl
-        run: | 
-          go install github.com/robotomize/go-allure/cmd/golurectl@latest
+        if: always()
+        run: |
+          go install github.com/robotomize/go-allure/cmd/[email protected]

       - name: Building Allure JSON
-        run: |
-          cat test_results.json | golurectl -l -e --allure-suite "Go Test" --allure-tags "Unit" -o ./allure-results
+        if: always()
+        run: |
+          if [ -s test_results.json ]; then
+            golurectl -l -e --allure-suite "Go Test" --allure-tags "Unit" -o ./allure-results < test_results.json
+          else
+            echo "No test_results.json to convert"
+          fi

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

.github/workflows/run-go-unit-tests.yml (9)

54-57: Avoid UUOC; read the file via stdin redirection.

Minor cleanup, same behavior.

-          cat test_results.json | golurectl -l -e --allure-suite "Go Test" --allure-tags "Unit" -o ./allure-results
+          golurectl -l -e --allure-suite "Go Test" --allure-tags "Unit" -o ./allure-results < test_results.json

---

46-49: Preserve test logs in step output while saving JSON.

Makes debugging easier in CI logs.

-          go test -json -cover ./... > test_results.json
+          go test -json -cover ./... | tee test_results.json > /dev/null

---

19-30: Broaden PR event types (optional).

Consider handling reopened and ready_for_review.

   pull_request:
     branches:
       - main
       - "stage/**"
     types:
-      - opened
-      - synchronize
+      - opened
+      - synchronize
+      - reopened
+      - ready_for_review

---

31-34: Set explicit token permissions (principle of least privilege).

Avoid unintended writes from actions that may push.

 jobs:
+permissions:
+  contents: read
   run-tests:
     runs-on: ubuntu-latest

---

75-79: Make artifact upload resilient and include raw inputs (optional).

Upload even on failures, and include allure-results and test_results.json for debugging.

-      - name: Upload Test Report 
-        uses: actions/upload-artifact@v4
-        with:
-          name: allure-report
-          path: allure-report
+      - name: Upload Test Report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: allure-report
+          path: allure-report
+
+      - name: Upload Allure Inputs
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: allure-inputs
+          path: |
+            allure-results
+            test_results.json

---

39-45: Consider removing check-latest for determinism.

Pinning to go.mod is already deterministic; check-latest can drift CI behavior unexpectedly.

       with:
         go-version-file: go.mod
         cache: true
-        check-latest: true

---

17-34: Add workflow concurrency to auto-cancel superseded runs.

Saves CI minutes and avoids racing artifact uploads.

 name: Run Go Tests

 on:
@@
-jobs:
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
   run-tests:
     runs-on: ubuntu-latest

---

50-53: Pin golurectl to v0.14.3 for reproducible builds

-          go install github.com/robotomize/go-allure/cmd/golurectl@latest
+          go install github.com/robotomize/go-allure/cmd/[email protected]

---

66-74: Clarify that allure-report-action doesn’t auto-publish; add deploy step
simple-elf/[email protected] only generates the report and history; it does not push to gh-pages. To publish, add a deploy step (e.g. peaceiris/actions-gh-pages) or enable Pages “Deploy from a branch,” passing github_token: ${{ secrets.GITHUB_TOKEN }} to that step. Optionally guard the deploy step with if: github.event_name == 'push' to avoid publishing from PRs.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

.github/workflows/run-go-unit-tests.yml (2)

17-30: Set explicit permissions for gh-pages writes.

If simple-elf/allure-report-action pushes to gh-pages, you need contents: write. Defaults can be read-only.

 name: Run Go Tests

 on:
   push:
     branches:
       - main
   pull_request:
     branches:
       - main
       - "stage/**"
     types:
       - opened
       - synchronize
+
+permissions:
+  contents: write

Please confirm whether the action commits/pushes; if not, ignore this.

---

35-41: Pin action and tool versions for supply-chain stability.

• Pin GitHub Actions to commit SHAs (checkout, setup-go, upload-artifact, simple-elf/allure-report-action).
• Avoid go install @latest; pin golurectl to a tagged version or commit.

If you want, I can propose SHAs after you confirm the exact versions you’d like to target.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro