Adapt the OpenBSD hvt tender to the new vmm(4) #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- VM memory allocation is now handled by vmm(4) - VMM_IOC_MPROTECT_EPT has been dropped some time ago, vmm(4) handles this now This commit breaks releases of OpenBSD (7.7 and before)
|
I wonder if there's anything we can have the conditional on, e.g. if we're <= 7.7 retain the current code, otherwise use this new code? |
I will agree with that. |
|
See omegametabroccolo#1 (which should work since openbsd/src@ca6cf18) EDIT: please note I didn't compile that commit, please check if it works :) |
|
Thanks, if @omegametabroccolo is happy, I can cherry-pick the commit and merge it. |
|
Yes that works, thanks! |
939db7d to
9355484
Compare
9355484 to
8e6deda
Compare
|
Thanks both! |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Sep 23, 2025
- Fix `test_ssp` on OpenBSD (@omegametabroccolo, Solo5/solo5#599) - Fix build of hvt on aarch64 (Solo5/solo5#601, @cmainas) - Adapt OpenBSD hvt tender with the new `vmm(4)` (@omegametabroccolo, @hannesm, Solo5/solo5#600)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Sep 23, 2025
- Fix `test_ssp` on OpenBSD (@omegametabroccolo, Solo5/solo5#599) - Fix build of hvt on aarch64 (Solo5/solo5#601, @cmainas) - Adapt OpenBSD hvt tender with the new `vmm(4)` (@omegametabroccolo, @hannesm, Solo5/solo5#600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this PR only works on -current and breaks released versions of OpenBSD. AFAICT there is no way to know at compile time if we're on -current or not, but we can check the latest released version with the
OpenBSDmacro from<sys/param.h>. We could wait until OpenBSD 7.8 is released to add some#if OpenBSD >= [7.8 version number]and support both 7.8 and earlier releases, as suggested in #598.