Skip to content

Fix broken add connection button #fixed #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kaspik merged 1 commit into from
Nov 25, 2020
Merged

Fix broken add connection button #fixed #551

Kaspik merged 1 commit into from
Nov 25, 2020

Conversation

@Jason-Morcos
Copy link
Member

@Jason-Morcos Jason-Morcos commented Nov 25, 2020

Changes:

  • The size of the connection payload changed with the previous release to include the cleartext plugin, however the size of the initialized array remained constant

Closes following issues:

Tested:

  • [] iMac / MacBook
  • macOS version:
  • Xcode version:

Screenshots:

Additional notes:

@Jason-Morcos Jason-Morcos requested a review from Kaspik November 25, 2020 20:56
@Jason-Morcos Jason-Morcos self-assigned this Nov 25, 2020
@Kaspik Kaspik merged commit 395006b into main Nov 25, 2020
@Kaspik Kaspik deleted the fix-broken-add-connection-button branch November 25, 2020 21:05
@Jason-Morcos Jason-Morcos restored the fix-broken-add-connection-button branch January 2, 2021 23:23
@Kaspik Kaspik deleted the fix-broken-add-connection-button branch April 4, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kaspik Kaspik Kaspik approved these changes

+1 more reviewer

@luzannew luzannew luzannew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Jason-Morcos Jason-Morcos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jason-Morcos @luzannew @Kaspik