Skip to content

Conversation

@bragov4ik
Copy link
Contributor

PR Info

Changes

  • Weaken requirements for TransactionError's generic parameter across all usage places I've found

Breaking Changes

I believe it's not a breaking change, since std::error::Error already requires these traits.

@bragov4ik
Copy link
Contributor Author

I've run cargo check and the repo seems to compile; I hope I didn't miss any place to update the requirements at

Copy link
Member

@Expurple Expurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Seems backward-compatible to me. Error already implied Debug + Display, but now E is no longer required to implement Error in addition to these.

@tyt2y3
Copy link
Member

tyt2y3 commented May 24, 2025

@Expurple thanks for confirming

@tyt2y3 tyt2y3 merged commit eade777 into SeaQL:master May 24, 2025
35 of 36 checks passed
@github-actions
Copy link

🎉 Released In 1.1.12 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use anyhow::Error in trasactions

3 participants