Skip to content

Conversation

@RohitRathore1
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #203 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   84.60%   84.78%   +0.18%     
==========================================
  Files          19       19              
  Lines        1604     1604              
==========================================
+ Hits         1357     1360       +3     
+ Misses        247      244       -3     
Impacted Files Coverage Δ
src/Optimization.jl 90.45% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcd827...335b170. Read the comment docs.

Project.toml Outdated
Sobol = "1.3"
Stheno = "0.6"
XGBoost = "0.4, 1.1"
Zygote = "0.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that test are passing with this version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry I had not checked all tests. It's not passing. I have removed it.


### Sampling

Let's define our bounds, this time we are working in two dimensions. In particular we want our first dimension `x` to have bounds `-10, 5`, and `0, 15` for the second dimension. We are taking 50 samples of the space using Sobol Sequences. We then evaluate our function on all of the sampling points.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is wrong: the first dimension has lb -10 and the second dimension has lb 5, while the upper bounds are 0 and 15 respectively, you got those a bit mixed up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it has got mixed up the first and second dimensions should be -5 and 10 for lb.

Using the sampled points we build the surrogate, the steps are analogous to the 1-dimensional case.

```@example RandomForestSurrogateND
RandomForest = RandomForestSurrogate(xys, zs, lower_bound, upper_bound)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also show the hyper parameters of the random forest, not just the standard call

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not right I think at the time of sampling I have used xys and zs respectively. So, when I will build a surrogate then I will have to call these parameters otherwise it will through error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am talking about the hyper parameters of the RandomForestSurrogate: you can for example change the value of the num_round kwarg

@ludoro ludoro merged commit 198f4e0 into SciML:master Jul 18, 2020
@RohitRathore1 RohitRathore1 deleted the random-forest branch August 1, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants