-
-
Notifications
You must be signed in to change notification settings - Fork 76
Random forest #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random forest #203
Conversation
upstream base repository
…7-10-18-05-10-276-3904821301 CompatHelper: bump compat for "Flux" to "0.11"
…7-10-11-04-39-973-4194802329 CompatHelper: add new compat entry for "Zygote" at version "0.5"
Inverse DistanceSurrogate
upstream base repository
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 84.60% 84.78% +0.18%
==========================================
Files 19 19
Lines 1604 1604
==========================================
+ Hits 1357 1360 +3
+ Misses 247 244 -3
Continue to review full report at Codecov.
|
Project.toml
Outdated
| Sobol = "1.3" | ||
| Stheno = "0.6" | ||
| XGBoost = "0.4, 1.1" | ||
| Zygote = "0.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that test are passing with this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry I had not checked all tests. It's not passing. I have removed it.
docs/src/randomforest.md
Outdated
|
|
||
| ### Sampling | ||
|
|
||
| Let's define our bounds, this time we are working in two dimensions. In particular we want our first dimension `x` to have bounds `-10, 5`, and `0, 15` for the second dimension. We are taking 50 samples of the space using Sobol Sequences. We then evaluate our function on all of the sampling points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is wrong: the first dimension has lb -10 and the second dimension has lb 5, while the upper bounds are 0 and 15 respectively, you got those a bit mixed up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it has got mixed up the first and second dimensions should be -5 and 10 for lb.
| Using the sampled points we build the surrogate, the steps are analogous to the 1-dimensional case. | ||
|
|
||
| ```@example RandomForestSurrogateND | ||
| RandomForest = RandomForestSurrogate(xys, zs, lower_bound, upper_bound) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also show the hyper parameters of the random forest, not just the standard call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am not right I think at the time of sampling I have used xys and zs respectively. So, when I will build a surrogate then I will have to call these parameters otherwise it will through error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am talking about the hyper parameters of the RandomForestSurrogate: you can for example change the value of the num_round kwarg
No description provided.