Skip to content

Conversation

@Blis204
Copy link

@Blis204 Blis204 commented Apr 7, 2023

Please describe the changes this PR makes and why it should be merged:

Added the ability to automatically let the bot leave the voice channel, after being alone for more than a given time.
The time can be changed in the bot config, or the module can be comlpetely disabled.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • This PR changes the library's interface (methods or parameters added)

Discord_kKNMrMb0B2

Copy link

@C-EO C-EO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest increasing the time to match the v5 setting of autoleave.

I mean 30 seconds! It becomes quite tiresome to have to summon the bot to the VC every single time.

@Blis204
Copy link
Author

Blis204 commented Apr 10, 2023

The default setting of auto leave is in the v5 version, on 30 seconds too

@C-EO
Copy link

C-EO commented Apr 12, 2023

The default setting of auto leave is in the v5 version, on 30 seconds too

@nikdraws I think making it 10 or 30 minutes will be okay too.

@C-EO
Copy link

C-EO commented Apr 12, 2023

I have no problem with it, just that the timing is unreal. What if I left the bot to get a cup of tea for two minutes and I expect it to still be connected to the VC?

@Assassin654
Copy link
Contributor

Assassin654 commented Apr 12, 2023

The default setting of auto leave is in the v5 version, on 30 seconds too

There is no default setting for the v5

In v5 it will leave the instant everyone is gone unless you configure it with 24/7, in which case you can configure the leave time.

@Blis204
Copy link
Author

Blis204 commented Apr 15, 2023

I have no problem with it, just that the timing is unreal. What if I left the bot to get a cup of tea for two minutes and I expect it to still be connected to the VC?

I added the ability to choose your own time, before disconnecting

@Blis204 Blis204 changed the title Bot can auto leave after 30 seconds Bot can auto leave after a given time Apr 15, 2023
@C-EO
Copy link

C-EO commented Apr 17, 2023

@Blis204 Now you're talking. Thanks for making the change

@Antoohh
Copy link

Antoohh commented May 4, 2023

there is one problem, whenever the bot is left alone in the channel, just someone connects the bot will play the music again but after the indicated time it will disconnect anyway.

@C-EO
Copy link

C-EO commented May 5, 2023

@Antoohh The problem is at your end then. @Blis204 covered your issue in the code as he committed it.

@stale
Copy link

stale bot commented Oct 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 1, 2023
@stale stale bot closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants