Shortening
#871
Shortening
#871
Conversation
Step one of the `shortening`: A project for making the existing code shorter and cleaner, while integrating pre existing utilities which never got to be used (util/getChannel.js) ;-;
|
there will be more changes being added to this in order to |
|
this repo is being flooded by prs ngl, anw i praise your english spellings here, you did a nice job |
It's a revolution Heh ⌓‿⌓ |
There was a problem hiding this comment.
The changes presented here bring a lot to the table, apart from the usage of the pre existing .util/getChannel.js also numerous little mods have been made to make the code cleaner and more effective.
This is not valid for the indentation as I was told to do so against my will.
Have fun finding all the bugs that may or may not exists within this PR.
The commands have been tested thoroughly enough to see if they actually work, but given this is a big commit there still may be some things we forgot. If you do find anything be sure to let us know through the discord support server or a new issue!
|
There are too many changes. The code is working fine? |
Yes, everything has been tested with help from fellow contributors while we were in a VC. As far as the functionalities of each commands goes everything is working as expected |
|
is it ready for merge or still needs commit? |
everything is ready |
|
|
* `Shortening` Step one of the `shortening`: A project for making the existing code shorter and cleaner, while integrating pre existing utilities which never got to be used (util/getChannel.js) ;-;
Please describe the changes this PR makes and why it should be merged:
Step one of the
shortening: A project for making the existing code shorter and cleaner, while integrating pre existing utilities which never got to be used (util/getChannel.js) ;-;Status and versioning classification:
NOTES:
The changes presented here bring a lot to the table, apart from the usage of the pre existing
.util/getChannel.jsalso numerous little mods have been made to make the code cleaner and more effective.This is not valid for the indentation as I was told to do so against my will.
Have fun finding all the bugs that may or may not exists within this PR.
The commands have been tested thoroughly enough to see if they actually work, but given this is a big commit there still may be some things we forgot. If you do find anything be sure to let us know through the discord support server or a new issue!