Use the central dir instead of the local file header (+ other patches) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like remove(), without any argument, we should just return `this`.
Also, add some unit tests.
Instead of reading the central dir and then the local dir (and trying to handle all the cases, data descriptors, data descriptors with zip64, etc) I just read the central dir, hoping that everything is here. (The only exception is the file name : for some reasons, some zip have the real name : with / instead of \ in the local dir) This fixes an issue with nested zip files and data descriptors. When the size was 0 in the local dir, we would seek the next occurence of the data descriptor signature. With zip containing data descriptors, this would lead to a bug. This should also help the issue Stuk#30 : the new code avoids the overhead of looking for data descriptors. Other change : I explained the limitations of the zip64 extensions in the browser.
|
Looks good! |
Stuk
added a commit
that referenced
this pull request
Feb 8, 2013
Use the central dir instead of the local file header (+ other patches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 3 issues :
folder()should be likeremove(): without any argument, just returnthis.See the commit messages for more details.