Skip to content

Conversation

jogibear9988
Copy link

No description provided.

@jogibear9988 jogibear9988 changed the title COnvert jszip to modern javascript code and use ESM modules Convert jszip to modern javascript code and use ESM modules Sep 14, 2025
@jogibear9988
Copy link
Author

NodejsStreamOutputAdapter
is not yet changed...
For what is it used? is it still needed?

@jogibear9988 jogibear9988 mentioned this pull request Sep 14, 2025
@andy0130tw
Copy link

andy0130tw commented Oct 9, 2025

@jogibear9988 I am bundling jszip into my project and I feel like that your conversion to ESM very useful to reduce the bundle size, with or without treeshaking. From the workflow environments this repo runs on, the upstream is maintaining compatibility dating back to Node v0.x. Maybe we can collaborate on a fork instead and make this PR minimal?

@jogibear9988
Copy link
Author

I allready created a fork
see: https://www.npmjs.com/package/@node-projects/jszip

@andy0130tw
Copy link

@jogibear9988 I mean, this is already a huge PR with ~20k lines changed. I do not think the author can review this PR and merge it someday.

@jogibear9988
Copy link
Author

I'm not sure if he ever will. As here are many open pull requests without any action.
But the changes are not so big, if you ignore whitespace changes, and also, that I've removed the bundeled files from the repo...
So if he only likes to merge the changes in the source files, this is not such a big task.

So what is your question?

As I said, I already created a fork.
Would you like to join?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants