[WIN32] Updated win32.yaml to better support dependency, fix build errors, add caching, speedup build time, and utilize vcpkg better #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to their latest major versions. Updates the paths to specific library files in the Windows workflow to ensure correct linking during the build process. This resolves potential build failures caused by incorrect library specifications. Simplifies the Windows build workflow by using a `vcpkg.json` file to declare dependencies. Updates the Windows workflow to use the v2 version of the MSBuild setup action and v4 of the cache actions. Enables the Win32 build workflow to be triggered on push events, in addition to manual triggering. Updates the win32 workflow to use the `github.workspace` variable instead of `runner.workspace`. Enables vcpkg dependency installations Sets the working directory for vcpkg install to ensure correct dependency resolution. This prevents potential issues related to relative paths and ensures that vcpkg operates within the expected workspace. Improves build times on Windows by caching the vcpkg and nuget directories using GitHub Actions cache. This avoids redownloading dependencies on each build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Windows build process with several key improvements:
vcpkg.jsonfile to declare project dependencies, simplifying the build workflow.github.workspacevariable instead ofrunner.workspace.